Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pypy windows #41

Closed
wants to merge 15 commits into from
Closed

Pypy windows #41

wants to merge 15 commits into from

Conversation

mattip
Copy link

@mattip mattip commented Aug 23, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Continuation of #38, but I cannot push to that branch.

Adds some patches for PyPy7.3.5 prolbmes that will be fixed for PyPy7.3.6

But in the end, we come up against

PythonService.cpp
win32/src/PythonService.cpp(622): error C3861: 'Py_SetProgramName': identifier not found
win32/src/PythonService.cpp(627): error C3861: 'Py_Initialize': identifier not found
win32/src/PythonService.cpp(639): error C3861: 'PySys_SetArgv': identifier not found

which is mhammond/pywin32#1289, with a potential work-around in a comment there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Author

mattip commented Aug 23, 2021

The azure pipelines builds are not shown in the "checks" section.

@carlodri
Copy link
Contributor

The azure pipelines builds are not shown in the "checks" section.

I'm experiencing the same thing across all conda-forge stuff, @conda-forge/core any idea on what's happening?

@mattip
Copy link
Author

mattip commented Aug 23, 2021

See conda-forge/status#117 for the tracking issue. So far there is no further information.

@carlodri
Copy link
Contributor

@mattip thank you for the feedback!

@isuruf
Copy link
Member

isuruf commented Aug 23, 2021

@conda-forge-admin, rerender

@mattip mattip force-pushed the pypy-windows branch 2 times, most recently from e20d0cd to 1b9b705 Compare August 24, 2021 10:23
@mattip mattip closed this Aug 24, 2021
@mattip
Copy link
Author

mattip commented Aug 24, 2021

reopen to restart CI

@mattip mattip reopened this Aug 24, 2021
@mattip
Copy link
Author

mattip commented Aug 24, 2021

CI is passing. I have removed a number of modules on PyPy, I hope that downstream dependencies will not fail because of that.

Removed modules:

  • pythoncom, and its dependents adsi, axcontrol, axscript, axdebug, internet, mapi, exchange, shell, propsys, taskscheduler, bits, ifilter, directsound, authorization
  • win32ui, and its dependents win32uiole, dde
  • servicemanager, pythonservice, and PyISAPI_loader

@mattip
Copy link
Author

mattip commented Aug 25, 2021

In a comment on the parallel pywin32 issue, the project manager ask that we not merge this since it is missing capabilities and the project does not want to deal with bug reports. Closing.

@mattip mattip closed this Aug 25, 2021
@akrherz akrherz mentioned this pull request Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@carlodri carlodri Awaiting requested review from carlodri

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@nicoddemus nicoddemus Awaiting requested review from nicoddemus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattip @conda-forge-linter @carlodri @isuruf